Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to primeface 7x #30

Merged
merged 5 commits into from
Feb 2, 2021
Merged

Upgrade to primeface 7x #30

merged 5 commits into from
Feb 2, 2021

Conversation

cuong95nddev
Copy link

Hi @hatemalimam, can you review my pull request.

@hatemalimam
Copy link
Owner

Hello @anhbinhvodanh,
Thanks for the PR, I'll have a look and get back to you.

@cuong95nddev
Copy link
Author

Hi @hatemalimam, Did you take a look at this pull request? Thanks.

@Rapster
Copy link

Rapster commented Jan 15, 2021

Would be great if this could be merged as it fixes #31

@cuong95nddev
Copy link
Author

Hi @hatemalimam it seems 1 year is too long for reviewing a pull request :))). Hope you can take a look.

@hatemalimam hatemalimam merged commit e82e6ac into hatemalimam:master Feb 2, 2021
@hatemalimam
Copy link
Owner

Hello @anhbinhvodanh sorry for the delay, I have merged the PR, but unfortunately it seems that something has changed regarding the publishing process to sonatype, I'll have to investigate that... unfortunately my time is limited these days... I'll see what I can do this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants